Skip to content

Adding IMERG datasets to main repo directory #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 27, 2025

Conversation

eni-awowale
Copy link
Contributor

From talking with @keewis these datasets need to live in the main repository folder so they can work with pooch

@eni-awowale eni-awowale marked this pull request as ready for review February 27, 2025 16:34
@keewis
Copy link
Contributor

keewis commented Feb 27, 2025

would it make sense to also change the extension to lower case (hdf5 instead of HDF5)? Otherwise this looks good to me.

@eni-awowale
Copy link
Contributor Author

@keewis Sure! The file extension being all caps is a holdover from the original granule name so yeah I can change it.

@keewis
Copy link
Contributor

keewis commented Feb 27, 2025

not sure why, but it looks like the file was duplicated instead of renamed?

@keewis
Copy link
Contributor

keewis commented Feb 27, 2025

Thanks, @eni-awowale. Since we discussed this during the meeting (where nobody objected), I'll go ahead and merge this. This will be a new feature, so even if there is an objection in the future it should be easy to change.

@keewis keewis merged commit b559632 into pydata:master Feb 27, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants