Lint (#3373)

* raise exception instance, not class

* isort

* isort

* Bump mypy version

Author: crusaderky

.pre-commit-config.yaml

@@ -11,7 +11,7 @@ repos:
     hooks:
       - id: flake8
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.720  # Must match ci/requirements/*.yml
+    rev: v0.730  # Must match ci/requirements/*.yml
     hooks:
       - id: mypy
   # run these occasionally, ref discussion https://github.com/pydata/xarray/pull/3194

asv_bench/benchmarks/__init__.py

@@ -18,7 +18,7 @@ def requires_dask():
     try:
         import dask  # noqa: F401
     except ImportError:
-        raise NotImplementedError
+        raise NotImplementedError()
 
 
 def randn(shape, frac_nan=None, chunks=None, seed=0):

asv_bench/benchmarks/dataset_io.py

@@ -458,7 +458,7 @@ def setup(self):
         try:
             import distributed
         except ImportError:
-            raise NotImplementedError
+            raise NotImplementedError()
         self.client = distributed.Client()
         self.write = create_delayed_write()
 

ci/requirements/py36-min-all-deps.yml

@@ -20,7 +20,7 @@ dependencies:
   - iris=2.2.0
   - lxml=4.4.1  # optional dep of pydap
   - matplotlib=3.1.1
-  - mypy==0.720  # Must match .pre-commit-config.yaml
+  - mypy==0.730  # Must match .pre-commit-config.yaml
   - nc-time-axis=1.2.0
   - netcdf4=1.5.1.2
   - numba=0.45.1

ci/requirements/py36.yml

@@ -20,7 +20,7 @@ dependencies:
   - iris>=1.10
   - lxml    # optional dep of pydap
   - matplotlib
-  - mypy==0.720  # Must match .pre-commit-config.yaml
+  - mypy==0.730  # Must match .pre-commit-config.yaml
   - nc-time-axis
   - netcdf4
   - numba

ci/requirements/py37-windows.yml

@@ -20,7 +20,7 @@ dependencies:
   - iris>=1.10
   - lxml    # optional dep of pydap
   - matplotlib
-  - mypy==0.720  # Must match .pre-commit-config.yaml
+  - mypy==0.730  # Must match .pre-commit-config.yaml
   - nc-time-axis
   - netcdf4
   - numba

ci/requirements/py37.yml

@@ -20,7 +20,7 @@ dependencies:
   - iris>=1.10
   - lxml    # optional dep of pydap
   - matplotlib
-  - mypy==0.720  # Must match .pre-commit-config.yaml
+  - mypy==0.730  # Must match .pre-commit-config.yaml
   - nc-time-axis
   - netcdf4
   - numba

properties/test_encode_decode.py

@@ -4,7 +4,7 @@
 These ones pass, just as you'd hope!
 
 """
-import pytest
+import pytest  # isort:skip
 
 pytest.importorskip("hypothesis")
 

xarray/backends/common.py

@@ -88,13 +88,13 @@ def __len__(self):
         return len(self.variables)
 
     def get_dimensions(self):  # pragma: no cover
-        raise NotImplementedError
+        raise NotImplementedError()
 
     def get_attrs(self):  # pragma: no cover
-        raise NotImplementedError
+        raise NotImplementedError()
 
     def get_variables(self):  # pragma: no cover
-        raise NotImplementedError
+        raise NotImplementedError()
 
     def get_encoding(self):
         return {}
@@ -247,13 +247,13 @@ def encode_attribute(self, a):
         return a
 
     def set_dimension(self, d, l):  # pragma: no cover
-        raise NotImplementedError
+        raise NotImplementedError()
 
     def set_attribute(self, k, v):  # pragma: no cover
-        raise NotImplementedError
+        raise NotImplementedError()
 
     def set_variable(self, k, v):  # pragma: no cover
-        raise NotImplementedError
+        raise NotImplementedError()
 
     def store_dataset(self, dataset):
         """

xarray/backends/file_manager.py

@@ -28,7 +28,7 @@ class FileManager:
 
     def acquire(self, needs_lock=True):
         """Acquire the file object from this manager."""
-        raise NotImplementedError
+        raise NotImplementedError()
 
     def acquire_context(self, needs_lock=True):
         """Context manager for acquiring a file. Yields a file object.
@@ -37,11 +37,11 @@ def acquire_context(self, needs_lock=True):
         (i.e., removes it from any cache) if an exception is raised from the
         context. It *does not* automatically close the file.
         """
-        raise NotImplementedError
+        raise NotImplementedError()
 
     def close(self, needs_lock=True):
         """Close the file object associated with this manager, if needed."""
-        raise NotImplementedError
+        raise NotImplementedError()
 
 
 class CachingFileManager(FileManager):