-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Don't warn when doing comparisons or arithmetic with NaN #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What's the preferred way of doing this? Same context manager technique as pandas? pandas-dev/pandas@ce61b3f |
Yes, using But as I noted in the StackOverflow answer, I think we actually already fixed this warning. You can find context managers with |
Is there a reason Travis would report them? While a lot of these are netCDF, there are a lot of From https://travis-ci.org/maxim-lian/xarray/jobs/346841400
|
It looks like we only silenced the warnings in comparisons/arithmetic, but not reductions. |
Right, I think we left #1652 to continue work on the reductions / other warnings. |
Right, I seem to be losing my memory - I put a comment in #1652 literally 8 days ago. Almost as much noise as the warnings output... |
Pandas used to unilaterally disable NumPy's warnings for doing comparisons with NaN, but now it doesn't: pandas-dev/pandas#13109
See also http://stackoverflow.com/questions/41130138/why-is-invalid-value-encountered-in-greater-warning-thrown-in-python-xarray-fo/41147570#41147570
The text was updated successfully, but these errors were encountered: