Skip to content

Allow all dims-as-kwargs methods to take a dict instead #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 of 7 tasks
max-sixty opened this issue May 26, 2018 · 4 comments
Closed
6 of 7 tasks

Allow all dims-as-kwargs methods to take a dict instead #2188

max-sixty opened this issue May 26, 2018 · 4 comments

Comments

@max-sixty
Copy link
Collaborator

max-sixty commented May 26, 2018

Follow up to #2174

Pasting from #2174 (comment)

  • stack
  • shift
  • roll
  • set_index
  • reorder_levels
  • rolling
  • resample (not yet, we still support old behavior for the first positional arguments with a warning)

...potentially rename (I often trip myself up on that)?

@fujiisoup
Copy link
Member

...potentially rename (I often trip myself up on that)?

Me too.
Similarly, chunks also?

@max-sixty
Copy link
Collaborator Author

Edited above - courtesy of @fujiisoup #2373, all done apart from resample

@stale
Copy link

stale bot commented Jul 25, 2020

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

@stale stale bot added the stale label Jul 25, 2020
@stale stale bot closed this as completed Aug 24, 2020
@keewis
Copy link
Collaborator

keewis commented Aug 24, 2020

this should have been closed by #2541.

@keewis keewis removed the stale label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants