Skip to content

Codecov bot comments? #3098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
max-sixty opened this issue Jul 11, 2019 · 2 comments · Fixed by #3140
Closed

Codecov bot comments? #3098

max-sixty opened this issue Jul 11, 2019 · 2 comments · Fixed by #3140

Comments

@max-sixty
Copy link
Collaborator

ref #3090 (comment)

Do we want the bot commenting on the PR, at least while the early checks are wrong? People can always click on Details in the Codecov check (e.g. https://codecov.io/gh/pydata/xarray/compare/8f0d9e5c9909c93a90306ed7cb5a80c1c2e1c97d...ab6960f623017afdc99c34bcbb69b402aea3f7d4/diff) to see a full report.

Happy to PR to disable, lmk
@shoyer
Copy link
Member

shoyer commented Jul 14, 2019

I have one more config tweak that I want to try before removing the comment: #3122

@shoyer
Copy link
Member

shoyer commented Jul 17, 2019

Yeah, that didn't work. Codecov still seems to be ignorant of the status of Azure checks, so let's turn the comment off.

@max-sixty max-sixty mentioned this issue Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable codecov comments max-sixty/xarray
2 participants
@shoyer @max-sixty