Skip to content

upstream-dev CI fails on import of dask.array #4124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keewis opened this issue Jun 5, 2020 · 9 comments
Closed

upstream-dev CI fails on import of dask.array #4124

keewis opened this issue Jun 5, 2020 · 9 comments

Comments

@keewis
Copy link
Collaborator

keewis commented Jun 5, 2020

I'm not sure why, but our upstream-dev CI fails when importing dask.array: https://dev.azure.com/xarray/xarray/_build/results?buildId=2996&view=logs&j=2280efed-fda1-53bd-9213-1fa8ec9b4fa8&t=aa9ddc6e-3e6c-56cb-4312-111c01d6f735

@keewis
Copy link
Collaborator Author

keewis commented Jun 6, 2020

It seems that's because we use python -OO -c "import xarray" to test importing, and the optimization (no asserts / __debug__ related stuff) makes import dask.array fail.

@dcherian
Copy link
Contributor

dcherian commented Jun 8, 2020

@jsignell
Copy link
Contributor

jsignell commented Jun 8, 2020

Working on a fix now. I think dask/dask#6299 should do it.

@dcherian
Copy link
Contributor

dcherian commented Jun 8, 2020

Awesome. Thanks @jsignell

@keewis
Copy link
Collaborator Author

keewis commented Jun 8, 2020

the fix by @jsignell is now on dask master so the upstream-dev CI should work, but our other CI will keep failing until dask=2.18.1 or dask=2.19.0 is released.

In the meantime, we could pin dask to dask!=2.18.0 or remove the -OO option in the CI. Does anyone know why we use that option?

@dcherian
Copy link
Contributor

dcherian commented Jun 9, 2020

or remove the -OO option in the CI. Does anyone know why we use that option?

Looks like @shoyer added that line initially. Lets try removing it?

@jsignell
Copy link
Contributor

jsignell commented Jun 9, 2020

I think dask is going to release today.

@shoyer
Copy link
Member

shoyer commented Jun 9, 2020

I would suggest pinning dask for now (or waiting until the new release).

@keewis
Copy link
Collaborator Author

keewis commented Jun 10, 2020

dask==2.18.1 has been released so I'm closing this

@keewis keewis closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants