Skip to content

Conventions decoding should properly handle byte type attributes on Python 3 #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shoyer opened this issue Jul 2, 2015 · 1 comment
Closed

Conventions decoding should properly handle byte type attributes on Python 3 #451

shoyer opened this issue Jul 2, 2015 · 1 comment
Labels
bug

Comments

@shoyer
Copy link
Member

shoyer commented Jul 2, 2015

This only appears with the h5netcdf backend (for now), because netCDF4-python decodes all string attributes to unicode on Python 3.

We might also fix this upstream in h5netcdf by copying this behavior from netCDF4-python.

xref #444 (comment)
@shoyer shoyer added the bug label Jul 2, 2015
@razcore-rad
Copy link

Yes, I think that this should be implemented in h5netcdf (possibly h5py? because h5netcdf depends on h5py I belive)

@shoyer shoyer mentioned this issue Jul 2, 2015
Closed
@shoyer shoyer changed the title Conventions decoding should properly handling byte type attributes on Python 3 Conventions decoding should properly handle byte type attributes on Python 3 Jul 2, 2015
@shoyer shoyer mentioned this issue Jul 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@razcore-rad @shoyer