-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix bulleted list indentation in docstrings #5250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@max-sixty, the inconsistencies are now fixed... |
Not sure there's a way to automatically detect these issues :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
the initial issue, at least, would have been caught by |
Right... In a previous comment #4872 (comment) you mentioned that the primary reason the xarray/.pre-commit-config.yaml Lines 27 to 30 in 9f11862
|
Maybe it's time to let Velin spring free! @keewis up to you, as ever |
@andersy005 I'll hit the button here, if that's OK with you? |
Thanks, @max-sixty |
Thank you @andersy005 ! |
no, I didn't.
I'll need to investigate more, but I think we should probably do that soon. There should be standard rst linters, too, but those might need more configuration: |
pre-commit run --all-files
As I understand it, the issue described in #5248 is caused by bad indentation... With this PR, we get the following:
@max-sixty, let me know if there are other instances that need to be fixed as part of this PR....