Enums created with functional syntax are now iterable. Close pylint-dev/pylint#992

Author: PCManticore

ChangeLog

@@ -4,6 +4,8 @@ Change log for the astroid package (used to be astng)
 --
    * Enums created with functional syntax are now iterable
 
+   * Enums created with functional syntax are now subscriptable
+
    * Don't crash when getting the string representation of BadUnaryOperationMessage
 
      In some cases, when the operand does not have a .name attribute,

astroid/brain/brain_namedtuple_enum.py

@@ -200,6 +200,16 @@ class EnumAttribute(object):
             return [EnumAttribute()]
         def __next__(self):
             return next(iter(self))
+        def __getitem__(self, attr):
+            class Value(object):
+                @property
+                def name(self):
+                    return ''
+                @property
+                def value(self):
+                    return attr
+
+            return Value()
     ''')
     class_node = infer_func_form(node, enum_meta,
                                  context=context, enum=True)[0]

astroid/tests/unittest_brain.py

@@ -584,6 +584,19 @@ def test_enum_func_form_iterable(self):
         self.assertIsInstance(inferred, astroid.Instance)
         self.assertTrue(inferred.getattr('__iter__'))
 
+    def test_enum_func_form_subscriptable(self):
+        instance, name = builder.extract_node('''
+        from enum import Enum
+        Animal = Enum('Animal', 'ant bee cat dog')
+        Animal['ant'] #@
+        Animal['ant'].name #@
+        ''')
+        instance = next(instance.infer())
+        self.assertIsInstance(instance, astroid.Instance)
+
+        inferred = next(name.infer())
+        self.assertIsInstance(inferred, astroid.Const)
+
 
 @unittest.skipUnless(HAS_DATEUTIL, "This test requires the dateutil library.")
 class DateutilBrainTest(unittest.TestCase):