Skip to content

Rename of branches is incorrect #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielNoord opened this issue Mar 17, 2022 · 7 comments
Closed

Rename of branches is incorrect #1479

DanielNoord opened this issue Mar 17, 2022 · 7 comments
Assignees
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow

Comments

@DanielNoord
Copy link
Collaborator

@Pierre-Sassoulas I think you might have done this, but I'm not sure.

Some time ago all branch names have been updated. This also included the 2.0 branch into maintenance/2.0.x. However, this was not the 2.0.x branch but rather a WIP branch for a complete overhaul of astroid, which has sadly failed.
See for example this issue #679, which refers to the branch and now links to the incorrectly named branch.

Since I did not do the change I do not know if there are any other branches that have been renamed incorrectly, but I would ask the person who did so to revisit the renaming and see if there are any other issues.

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Mar 17, 2022
@Pierre-Sassoulas
Copy link
Member

Yeap, that's me 😄

@Pierre-Sassoulas
Copy link
Member

Renamed to 2.0.experimental

@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas Should we remove some of those maintenance branches? We don't really use those and you can checkout the tag if you want to see them.

@Pierre-Sassoulas
Copy link
Member

Yeah maybe all of them but the current one ? I was keeping them because they were there , but I think you're right. (And we really don't want to maintain astroid 2.1)

@DanielNoord
Copy link
Collaborator Author

Yeah I think so. I like to keep my branches clean as it shows what is actually being worked on within a project.

@Pierre-Sassoulas
Copy link
Member

I don't know what we should do with the 2.0 experimental branch now.

@DanielNoord
Copy link
Collaborator Author

Let's keep it around. There is no tag for it and it is good reference to look into for some open issues + what other solutions to common problems have been thgouht of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

No branches or pull requests

2 participants