From 39bf1a0bd67648fafc9c7dc5c5d35bcc44ab0457 Mon Sep 17 00:00:00 2001 From: Maxim Kochurov Date: Thu, 21 Sep 2023 09:51:19 +0100 Subject: [PATCH 1/2] Update r2d2m2cp.py --- pymc_experimental/distributions/multivariate/r2d2m2cp.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pymc_experimental/distributions/multivariate/r2d2m2cp.py b/pymc_experimental/distributions/multivariate/r2d2m2cp.py index 55096ea9d..0b38ebd21 100644 --- a/pymc_experimental/distributions/multivariate/r2d2m2cp.py +++ b/pymc_experimental/distributions/multivariate/r2d2m2cp.py @@ -193,8 +193,7 @@ def _phi( raise TypeError("Can't use variance explained with less than two variables") phi = pt.as_tensor(variance_explained) else: - phi = 1 / len(model.coords[dim]) - phi = _broadcast_as_dims(phi, dims=dims) + phi = _broadcast_as_dims(1., dims=dims) if importance_concentration is not None: return pm.Dirichlet("phi", importance_concentration * phi, dims=broadcast_dims + [dim]) else: From f117ba1449a012e67676a392c9653d27f09700d4 Mon Sep 17 00:00:00 2001 From: Maxim Kochurov Date: Fri, 29 Sep 2023 23:44:38 +0300 Subject: [PATCH 2/2] Update r2d2m2cp.py --- pymc_experimental/distributions/multivariate/r2d2m2cp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pymc_experimental/distributions/multivariate/r2d2m2cp.py b/pymc_experimental/distributions/multivariate/r2d2m2cp.py index 0b38ebd21..62c706de4 100644 --- a/pymc_experimental/distributions/multivariate/r2d2m2cp.py +++ b/pymc_experimental/distributions/multivariate/r2d2m2cp.py @@ -193,7 +193,7 @@ def _phi( raise TypeError("Can't use variance explained with less than two variables") phi = pt.as_tensor(variance_explained) else: - phi = _broadcast_as_dims(1., dims=dims) + phi = _broadcast_as_dims(1.0, dims=dims) if importance_concentration is not None: return pm.Dirichlet("phi", importance_concentration * phi, dims=broadcast_dims + [dim]) else: