Skip to content

Submitting PR for BEST as a "default model" #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericmjl opened this issue Nov 7, 2016 · 4 comments
Closed

Submitting PR for BEST as a "default model" #1502

ericmjl opened this issue Nov 7, 2016 · 4 comments

Comments

@ericmjl
Copy link
Member

ericmjl commented Nov 7, 2016

Hi PyMC devs!

I'd like to explore what would be the value of "default" models in PyMC3 here.

I looked through the BEST model, and after thinking through it, I did a bit of software tweaks to extend it from a two-treatment comparison to multi-treatment. I like the BEST model, because it applies quite nicely in the life sciences, particularly when we don't necessarily have good underlying theory for describing the data generation process.

Seeing how the GLM module sort of acts like a nice "default" model in PyMC3, would there be value in adding a multi-treatment BEST model as another "default" model? I think having "default" models present, and an example of how to structure the data to bring it into the model, would be a good way to help with the adoption of PyMC3 and Bayesian methods.

I have wrapped my own "default model" for high throughput measurements in a Python script, which I think is equivalent to multi-treatment comparison; I'd also love to see if I've made any mistakes in implementing it, or if I'm making a noob-ish fundamental (theoretical) mistake!

@ericmjl ericmjl changed the title Submitting PR for BEST extension Submitting PR for BEST as "default model" Nov 7, 2016
@twiecki
Copy link
Member

twiecki commented Nov 7, 2016

I completely agree. Currently pymc3 is just a toolbox to build models but certainly it would be helpful to already have pre-existing models that can be used out of the box. Maybe either in a separate repo or maybe as a modules submodule. Maybe also apply the sklearn API which is pretty nice. Want to do a PR?

@ericmjl
Copy link
Member Author

ericmjl commented Nov 7, 2016

Happy to work on it! 😄

@ericmjl ericmjl changed the title Submitting PR for BEST as "default model" Submitting PR for BEST as a "default model" Nov 7, 2016
@ericmjl ericmjl mentioned this issue Nov 10, 2016
@ericmjl
Copy link
Member Author

ericmjl commented Nov 10, 2016

@twiecki PR #1517 is submitted! Please let me know what you think about the API design and the notebook. I'm happy to make changes if needed.

I took your suggestion on the scikit-learn-ish API, and provided a .fit() and a .plot_posterior() function, which I think can be "standard" API calls for default models.

@twiecki
Copy link
Member

twiecki commented Dec 6, 2016

Closing in favor of #1517.

@twiecki twiecki closed this as completed Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants