Skip to content

Remove RNG initialization from theanof. #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aseyboldt opened this issue May 8, 2017 · 2 comments
Closed

Remove RNG initialization from theanof. #2144

aseyboldt opened this issue May 8, 2017 · 2 comments
Labels
beginner friendly

Comments

@aseyboldt
Copy link
Member

Most of the time it takes to import pymc is spend in pymc3.theanof initializing something related to the theano rng: https://github.com/pymc-devs/pymc3/blob/master/pymc3/theanof.py#L374
On my machine it spends ~4 of a total of 5s there. Seems a bit excessive.
@ferrine That was introduced in #1694. Any idea why this would take so long?
@ferrine
Copy link
Member

ferrine commented May 8, 2017 •
edited
Loading

That's for sure this line. Rng is compiled. I added this code as I got a strange error (raise on no test value) when using rng later in code.

@ferrine
Copy link
Member

ferrine commented May 8, 2017

after #2103 this step can be removed

@twiecki twiecki changed the title Time to import pymc Remove RNG initialization from theanof. May 8, 2017
@ferrine ferrine mentioned this issue May 12, 2017
Merged
@twiecki twiecki closed this as completed May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@twiecki @aseyboldt @ferrine