Skip to content

Numpy style docstrings? #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ColCarroll opened this issue Jul 10, 2017 · 4 comments
Closed

Numpy style docstrings? #2403

ColCarroll opened this issue Jul 10, 2017 · 4 comments

Comments

@ColCarroll
Copy link
Member

pydocstyle merged in checking for numpy style docstrings this year. I'm intending to open a PR to get pymc3/step_methods/hmc, which currently has 45 violations, to conform to this, which might help get a discussion about doing that for the rest of the project, which has 1,381 violations.

The benefits are that it will allow us to use more of the documentation tools being built for the rest of the python science stack. The downsids are that it is one more hurdle to jump on PRs, and it can discourage quick iteration. There's a half-step I sort of like of enabling it for specific directories.

pydocstyle --convention=numpy pymc3/step_methods/hmc/ 

To see current problems!

@ColCarroll
Copy link
Member Author

@ColCarroll
Copy link
Member Author

Note:
This won't enforce that every argument is documented, or every return value. However, see scikit-learn/scikit-learn#9206, which looks to be on the verge of merging. That could be an interesting followup!

@junpenglao
Copy link
Member

This is a good idea. Also I suppose lots of docstrings might be quite similar so it might not be as difficult as it sounds (still difficult with 1381 violations tho...)
We should put this into our Docathon goal.

@ColCarroll
Copy link
Member Author

Closing since I do not think this is pressing, but it sounds like this is generally welcome if contributors want to update some documentation (doesn't have to be the whole project)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants