Skip to content

Perform single call to aeppl.factorized_joint_logprob when calling model.logpt #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ricardoV94 opened this issue Nov 30, 2021 · 0 comments · Fixed by #5245
Closed

Perform single call to aeppl.factorized_joint_logprob when calling model.logpt #5230

ricardoV94 opened this issue Nov 30, 2021 · 0 comments · Fixed by #5245

Comments

@ricardoV94
Copy link
Member

For model.logpt we are calling model.datalogpt and model.varlogpt, each of which calls aeppl.factorized_joint_logprob. It should be possible to do a single call to aeppl with all the free and observed model variables, which would save quite a lot of repeated operations on the aeppl side. For some reason this was not working when we tried it in #5166 and #4887.

logp_var = self.varlogpt + self.datalogpt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant