Skip to content

Rename SMC files #6171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ricardoV94 opened this issue Oct 1, 2022 · 1 comment · Fixed by #6174
Closed

Rename SMC files #6171

ricardoV94 opened this issue Oct 1, 2022 · 1 comment · Fixed by #6174
Labels
beginner friendly maintenance SMC Sequential Monte Carlo

Comments

@ricardoV94
Copy link
Member

I think we should call sample_smc.py, sampling.py as it's already inside the smc module anyway. smc.py would be better named kernels.py

CC @aloctavodia
@ricardoV94 ricardoV94 changed the title Rename smc modules Rename SMC modules Oct 1, 2022
@ricardoV94 ricardoV94 added SMC Sequential Monte Carlo maintenance labels Oct 1, 2022
@ricardoV94 ricardoV94 changed the title Rename SMC modules Rename SMC files Oct 1, 2022
@aloctavodia
Copy link
Member

Sounds good to me. And I agree with the names too

This was referenced Oct 2, 2022
Closed
Merged
@ricardoV94 ricardoV94 mentioned this issue Oct 28, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly maintenance SMC Sequential Monte Carlo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renamed SMC files
Rename SMC files
2 participants
@aloctavodia @ricardoV94