Skip to content

Make sponsor images have the same size #6586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twiecki opened this issue Mar 11, 2023 · 12 comments
Closed

Make sponsor images have the same size #6586

twiecki opened this issue Mar 11, 2023 · 12 comments

Comments

@twiecki
Copy link
Member

twiecki commented Mar 11, 2023

Description

Currently the sponsor section in the readme looks like this:
image

We should make it so that they all have the same size.

@aniketpancharia
Copy link

Hello @twiecki I would like to take up this issue can you please elaborate what would be the preferred end product of this image ?

@twiecki
Copy link
Member Author

twiecki commented Mar 12, 2023

@aniketpancharia That's great. The way we have it on https://www.pymc.io/welcome.html would be ideal:

image

@aniketpancharia
Copy link

ok thanks for the help @twiecki

@18bce133
Copy link

Hey @twiecki, I have tried to resolve this issue. Here's the README of my fork. It looks like this:

image

Let me know if you have anything else in mind. Thanks!

@twiecki
Copy link
Member Author

twiecki commented Mar 16, 2023

@18bce133 That looks much better! If possible, would be nice to have a little padding/space between the logos, but no big deal if that's difficult. Feel free to open a PR.

@twiecki
Copy link
Member Author

twiecki commented Mar 16, 2023

@18bce133 Ah, I just looked at how you did it, ideally there's a way in rst to scale images, you scaled the images directly. Maybe this helps: https://stackoverflow.com/a/71929401

@18bce133
Copy link

Hi @twiecki, thank you for your reply and suggestions. I have resized image in rst rather than rescaling the image. I tried to do padding but RST does not seems to have padding attribute in image directive.
image

Let me know if any other changes are to be expected. Thanks !

@twiecki
Copy link
Member Author

twiecki commented Mar 17, 2023

@18bce133 Much better, can you drop the height? The mistplay logo is getting squeezed a bit.

@18bce133
Copy link

Hi @twiecki , Thank you for your reply and kind suggestions, I resized all the three images to same dimensions so that they appear symmetrical. But still as you suggested I have dropped the height of Mistplay Logo by 5px.

image

Let me know if any other changes are to be expected. Thanks !

@twiecki
Copy link
Member Author

twiecki commented Mar 24, 2023

@18bce133 Great, want to open a PR?

@twiecki
Copy link
Member Author

twiecki commented Apr 3, 2023

@18bce133 Any progress?

@reshamas
Copy link
Member

reshamas commented Apr 3, 2023

@twiecki
This issue is resolve via #6643
See page:
https://github.com/pymc-devs/pymc/blob/main/README.rst

@twiecki twiecki closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants