-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Make sponsor images have the same size #6586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello @twiecki I would like to take up this issue can you please elaborate what would be the preferred end product of this image ? |
@aniketpancharia That's great. The way we have it on https://www.pymc.io/welcome.html would be ideal: |
ok thanks for the help @twiecki |
@18bce133 That looks much better! If possible, would be nice to have a little padding/space between the logos, but no big deal if that's difficult. Feel free to open a PR. |
@18bce133 Ah, I just looked at how you did it, ideally there's a way in rst to scale images, you scaled the images directly. Maybe this helps: https://stackoverflow.com/a/71929401 |
Hi @twiecki, thank you for your reply and suggestions. I have resized image in rst rather than rescaling the image. I tried to do padding but RST does not seems to have padding attribute in image directive. Let me know if any other changes are to be expected. Thanks ! |
@18bce133 Much better, can you drop the height? The mistplay logo is getting squeezed a bit. |
Hi @twiecki , Thank you for your reply and kind suggestions, I resized all the three images to same dimensions so that they appear symmetrical. But still as you suggested I have dropped the height of Mistplay Logo by 5px. Let me know if any other changes are to be expected. Thanks ! |
@18bce133 Great, want to open a PR? |
@18bce133 Any progress? |
@twiecki |
Description
Currently the sponsor section in the readme looks like this:

We should make it so that they all have the same size.
The text was updated successfully, but these errors were encountered: