Remove no-binary disabling the cache of locally built wheels

Author: sbidoul

news/11453.removal.rst

@@ -0,0 +1,2 @@
+``--no-binary`` does not disable the cache of locally built wheels anymore. It only
+means "don't download wheels".

src/pip/_internal/cli/cmdoptions.py

@@ -1000,7 +1000,7 @@ def check_list_path_option(options: Values) -> None:
     choices=[
         "fast-deps",
         "truststore",
-        "no-binary-enable-wheel-cache",
+        "no-binary-enable-wheel-cache",  # now always on
     ],
     help="Enable new functionality, that may be backward incompatible.",
 )

src/pip/_internal/commands/install.py

@@ -30,10 +30,7 @@
     check_legacy_setup_py_options,
 )
 from pip._internal.utils.compat import WINDOWS
-from pip._internal.utils.deprecation import (
-    LegacyInstallReasonFailedBdistWheel,
-    deprecated,
-)
+from pip._internal.utils.deprecation import LegacyInstallReasonFailedBdistWheel
 from pip._internal.utils.filesystem import test_writable_dir
 from pip._internal.utils.logging import getLogger
 from pip._internal.utils.misc import (
@@ -347,23 +344,9 @@ def run(self, options: Values, args: List[str]) -> int:
             check_legacy_setup_py_options(options, reqs)
 
             if "no-binary-enable-wheel-cache" in options.features_enabled:
-                # TODO: remove format_control from WheelCache when the deprecation cycle
-                # is over
-                wheel_cache = WheelCache(options.cache_dir)
-            else:
-                if options.format_control.no_binary:
-                    deprecated(
-                        reason=(
-                            "--no-binary currently disables reading from "
-                            "the cache of locally built wheels. In the future "
-                            "--no-binary will not influence the wheel cache."
-                        ),
-                        replacement="to use the --no-cache-dir option",
-                        feature_flag="no-binary-enable-wheel-cache",
-                        issue=11453,
-                        gone_in="23.1",
-                    )
-                wheel_cache = WheelCache(options.cache_dir, options.format_control)
+                logger.warning("no-binary-enable-wheel-cache is now active by default.")
+
+            wheel_cache = WheelCache(options.cache_dir)
 
             # Only when installing is it permitted to use PEP 660.
             # In other circumstances (pip wheel, pip download) we generate

src/pip/_internal/commands/wheel.py

@@ -14,7 +14,6 @@
     InstallRequirement,
     check_legacy_setup_py_options,
 )
-from pip._internal.utils.deprecation import deprecated
 from pip._internal.utils.misc import ensure_dir, normalize_path
 from pip._internal.utils.temp_dir import TempDirectory
 from pip._internal.wheel_builder import build, should_build_for_wheel_command
@@ -107,7 +106,6 @@ def run(self, options: Values, args: List[str]) -> int:
         session = self.get_default_session(options)
 
         finder = self._build_package_finder(options, session)
-        wheel_cache = WheelCache(options.cache_dir, options.format_control)
 
         options.wheel_dir = normalize_path(options.wheel_dir)
         ensure_dir(options.wheel_dir)
@@ -124,23 +122,9 @@ def run(self, options: Values, args: List[str]) -> int:
         check_legacy_setup_py_options(options, reqs)
 
         if "no-binary-enable-wheel-cache" in options.features_enabled:
-            # TODO: remove format_control from WheelCache when the deprecation cycle
-            # is over
-            wheel_cache = WheelCache(options.cache_dir)
-        else:
-            if options.format_control.no_binary:
-                deprecated(
-                    reason=(
-                        "--no-binary currently disables reading from "
-                        "the cache of locally built wheels. In the future "
-                        "--no-binary will not influence the wheel cache."
-                    ),
-                    replacement="to use the --no-cache-dir option",
-                    feature_flag="no-binary-enable-wheel-cache",
-                    issue=11453,
-                    gone_in="23.1",
-                )
-            wheel_cache = WheelCache(options.cache_dir, options.format_control)
+            logger.warning("no-binary-enable-wheel-cache is now active by default.")
+
+        wheel_cache = WheelCache(options.cache_dir)
 
         preparer = self.make_requirement_preparer(
             temp_build_dir=directory,

tests/functional/test_install.py

@@ -1677,27 +1677,6 @@ def test_install_no_binary_uses_local_backend(
     assert os.path.isfile(marker), "Local PEP 517 backend not used"
 
 
-@pytest.mark.usefixtures("with_wheel")
-def test_install_no_binary_disables_cached_wheels(
-    script: PipTestEnvironment, data: TestData
-) -> None:
-    # Seed the cache
-    script.pip("install", "--no-index", "-f", data.find_links, "upper")
-    script.pip("uninstall", "upper", "-y")
-    res = script.pip(
-        "install",
-        "--no-index",
-        "--no-binary=:all:",
-        "-f",
-        data.find_links,
-        "upper",
-        expect_stderr=True,
-    )
-    assert "Successfully installed upper-2.0" in str(res), str(res)
-    # upper is built and not obtained from cache
-    assert "Building wheel for upper" in str(res), str(res)
-
-
 def test_install_editable_with_wrong_egg_name(
     script: PipTestEnvironment, resolver_variant: ResolverVariant
 ) -> None: