Merge pull request #10844 from pradyunsg/accept-lowercase-doctype

pradyunsg · web-flow · commit 9dec8a5e59f5 · 2022-01-30T16:53:55.000Z
diff --git a/news/10844.bugfix.rst b/news/10844.bugfix.rst
@@ -0,0 +1 @@
+Accept lowercase ``<!doctype html>`` on index pages.
diff --git a/src/pip/_internal/index/collector.py b/src/pip/_internal/index/collector.py
@@ -401,7 +401,7 @@ def __init__(self, *args: Any, **kwargs: Any) -> None:
         self.anchors: List[Dict[str, Optional[str]]] = []
 
     def handle_decl(self, decl: str) -> None:
-        if decl != "DOCTYPE html":
+        if decl.lower() != "doctype html":
             self._raise_error()
         self._seen_decl = True
 
diff --git a/tests/data/indexes/yanked/simple/index.html b/tests/data/indexes/yanked/simple/index.html
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!doctype html>
 <html>
   <body>
     <a href="../../../packages/simple-1.0.tar.gz">simple-1.0.tar.gz</a>

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Accept lowercase ``<!doctype html>`` on index pages.
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<!DOCTYPE html>`
	`1`	`+<!doctype html>`
`2`	`2`	`<html>`
`3`	`3`	`<body>`
`4`	`4`	`<a href="../../../packages/simple-1.0.tar.gz">simple-1.0.tar.gz</a>`