Don't attempt to build requirements that don't need to be installed

sbidoul · sbidoul · commit 9deead0ba1c3 · 2025-04-29T08:37:13.000+02:00
requirements_to_install is scheduled for removal together with
the legacy resolver, at which point we should be able to use
all requirements returned by resolve() unconditionally.
diff --git a/news/13353.bugfix.rst b/news/13353.bugfix.rst
@@ -0,0 +1 @@
+Fix ``req.source_dir`` AssertionError when using the legacy resolver.
diff --git a/src/pip/_internal/commands/install.py b/src/pip/_internal/commands/install.py
@@ -420,7 +420,7 @@ def run(self, options: Values, args: List[str]) -> int:
 
             reqs_to_build = [
                 r
-                for r in requirement_set.requirements.values()
+                for r in requirement_set.requirements_to_install
                 if should_build_for_install_command(r)
             ]
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix ``req.source_dir`` AssertionError when using the legacy resolver.
Original file line number	Diff line number	Diff line change
`@@ -420,7 +420,7 @@ def run(self, options: Values, args: List[str]) -> int:`
`420`	`420`
`421`	`421`	`reqs_to_build = [`
`422`	`422`	`r`
`423`		`- for r in requirement_set.requirements.values()`
	`423`	`+ for r in requirement_set.requirements_to_install`
`424`	`424`	`if should_build_for_install_command(r)`
`425`	`425`	`]`
`426`	`426`