Skip to content

requirements file handling with --save option #8082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jnoortheen opened this issue Apr 19, 2020 · 7 comments
Closed

requirements file handling with --save option #8082

jnoortheen opened this issue Apr 19, 2020 · 7 comments

Comments

@jnoortheen
Copy link

What's the problem this feature will solve?

It will solve the issue described in #1479

Describe the solution you'd like

  • add --save option to install, uninstall commands

I have created a wrapper around pip called pipm. It doesn't depend on anything other than pip and stdlib.
setup.cfg -> as the metafile
requirements.txt -> as the lockfile

Is it possible to add those features pip itself? I just wanted to know before proceeding to create a pull request.

@ghost ghost added the S: needs triage Issues/PRs that need to be triaged label Apr 19, 2020
@McSinyx
Copy link
Contributor

McSinyx commented Apr 19, 2020

Hi there, FYI there's a ongoing development for requirements.txt: Pipfile, which is now currently handled by Pipenv. I don't have any opinion on this particular issue though.

@jnoortheen
Copy link
Author

Yes I know about that those things. There has no recent release of pipenv (I think it was on 2018), because of its own set of issues. Poetry seems more robust. Here the change is very little but will make pip as a standalone tool for development, without the need for pip-tools.

@McSinyx
Copy link
Contributor

McSinyx commented Apr 19, 2020

Pipenv's next release will be in a very near future. I'm not sure what's the vision for pip to be though--I've always been thinking that it is a package manager rather than a collection of common utils for development. I could be wrong though, and it is best for a pip's maintainer to answer this question.

@xavfernandez
Copy link
Member

@jnoortheen as you've mentionned yourself this is a duplicate of #1479.
Please keep the discussion in a single issue.

@jnoortheen
Copy link
Author

I am asking if I can start creating a PR for this feature. Does pip want to have this by default?

@uranusjr
Copy link
Member

  1. This question should have been asked in the old issue.
  2. I don’t think using setup.cfg is viable since configparser is incapable of doing round-trip read-write. It may work for certain usages, but once you put it in pip users will come asking for “reasonable” features it can never implement. I’m about -0 on the idea in general, but strongly object to this particular proposal.

@jnoortheen
Copy link
Author

Is it possible to add those features pip itself? I just wanted to know before proceeding to create a pull request.

  1. I did ask in the issue description.

  2. OK.

@pradyunsg pradyunsg removed the S: needs triage Issues/PRs that need to be triaged label Feb 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants