Skip to content

Commit 3eb5ff9

Browse files
committed
Fixed TypeError when a unicode generator name was passed on Python 2.7
Fixes #388.
1 parent e6102e5 commit 3eb5ff9

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

docs/news.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
Release Notes
22
=============
33

4+
**UNRELEASED**
5+
6+
- Fixed regression introduced in 0.36.0 on Python 2.7 when a custom generator
7+
name was passed as unicode (Scikit-build)
8+
(``TypeError: 'unicode' does not have the buffer interface``)
9+
410
**0.36.0 (2020-12-01)**
511

612
- Added official Python 3.9 support

src/wheel/bdist_wheel.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,11 @@ def run(self):
373373

374374
def write_wheelfile(self, wheelfile_base, generator='bdist_wheel (' + wheel_version + ')'):
375375
from email.message import Message
376+
377+
# Workaround for Python 2.7 for when "generator" is unicode
378+
if sys.version_info < (3,) and not isinstance(generator, str):
379+
generator = generator.encode('utf-8')
380+
376381
msg = Message()
377382
msg['Wheel-Version'] = '1.0' # of the spec
378383
msg['Generator'] = generator

0 commit comments

Comments
 (0)