You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As fallout from #346, there was a change in behavior. Previously, a user could specify a plat-name and bdist_wheel would create a binary wheel with that plat-name. This is tested for in test_plat_name_ext. Before that PR the test passed, after it the test is skipped (the failed assert in get_tag is misinterpreted as an inability to compile).
Arguably, the previous behavior was unintentional intended but questionable since
there is a comment that only pure wheels should be allowed to specify plat-name
it is not clear how pip would install such a wheel
I guess it would be nice to add a blurb like "Fixed regression in v35 where --plat-name was ignored for c-extension packages. Also fixed faulty test for this flag"
Uh oh!
There was an error while loading. Please reload this page.
As fallout from #346, there was a change in behavior. Previously, a user could specify a
plat-name
andbdist_wheel
would create a binary wheel with thatplat-name
. This is tested for intest_plat_name_ext
. Before that PR the test passed, after it the test is skipped (the failed assert inget_tag
is misinterpreted as an inability to compile).Arguably, the previous behavior was
unintentionalintended but questionable sinceplat-name
As @carljm points out in this comment, it is a change in behaviour.
The text was updated successfully, but these errors were encountered: