Skip to content

Commit 2eb90a2

Browse files
committed
Slightly improve PR template
1 parent a1a1d37 commit 2eb90a2

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+8-4
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
## Checklist
88

99
<!--
10-
- Choose the section(s) relevant to your PR and answer the questions. A section is indicated by `### Heading`.
11-
- Non-applying sections can be ignored or removed.
10+
- Choose the section(s) relevant to your PR and answer the questions. A section is indicated by `### Heading`. Skip non-applying sections.
1211
- Place an `x` in the [ ] for yes, leave it empty for no. If a question is not applicable, remove the [ ], but keep the message in place.
1312
- Use the Preview tab to confirm the PR will render correctly.
1413
-->
@@ -26,8 +25,13 @@
2625
### Setup
2726

2827
- [ ] This PR changes setup code (`setupsrc/`, `setup.py` etc.).
28+
- [ ] I have read through relevant doc sections [Installation -> From source][1] and [Setup Magic][2].
2929
- [ ] I have tested the change does not break internal callers.
3030
- [ ] I believe the change is maintainable and does not cause unreasonable complexity or code pollution.
31-
- [ ] The change does not try to shift a maintenance burden or upstream downstream tasks. *Keep handlers generic, avoid overly downstream-specific or effectively dead code passages.*
32-
- [ ] I have assessed that the targeted use case cannot reasonably be satisfied by existing means, or the change forms a notable improvement over possible alternatives.
31+
- [ ] The change does not try to shift a maintenance burden or upstream downstream tasks. *Keep handlers generic, avoid overly downstream-specific or (for us) effectively dead code passages.*
32+
- [ ] I have assessed that the targeted use case cannot reasonably be satisfied by existing means, such as [Caller-provided data files][3], or the change forms a notable improvement over possible alternatives.
3333
- [ ] I believe the targeted use case is supported by pypdfium2-team. *Note that we may not want to support esoteric or artificially restricted setup envs.*
34+
35+
[1]: https://github.com/pypdfium2-team/pypdfium2?tab=readme-ov-file#install-source
36+
[2]: https://github.com/pypdfium2-team/pypdfium2?tab=readme-ov-file#setup-magic
37+
[3]: https://github.com/pypdfium2-team/pypdfium2?tab=readme-ov-file#install-source-caller

0 commit comments

Comments
 (0)