Skip to content

Commit 54d2ffc

Browse files
committed
craft/conda: update a code comment
1 parent 59dc178 commit 54d2ffc

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

setupsrc/pypdfium2_setup/craft_packages.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -213,10 +213,11 @@ def main_conda_helpers(args):
213213
class TmpCommitCtx:
214214

215215
# https://github.com/conda/conda-build/issues/5045
216-
# Work around local conda `git_url` not including uncommitted changes
216+
# Work around local conda `git_url` not including uncommitted changes.
217217
# We can't reasonably use `path` since it does not honor gitignore rules, but would copy all files, including big generated directories like sourcebuild/
218-
# On the other hand, transferring generated files with `git_url` tends to be problematic, as a tmp commit renders the initial repo state invalid.
219-
# Alternatively, we could perhaps make a clean copy of required files (e.g. using the sdist) and using `path` instead of git hacks?
218+
# Including uncommitted changes is more convenient with development, and particularly relevant as we want to transfer externally generated data files.
219+
# However, note that what we are doing is an unusual way of using conda: normally, packaging would be done in an external repo which downloads the source first, and all files would be generated within the conda-build call.
220+
# We've been trying to bend conda into PyPA-like packaging within the project's infrastructure, but turns out it's not really intended like that....
220221

221222
# use a tmp control file so we can also undo the commit in conda's isolated clone
222223
FILE = CondaDir / "with_tmp_commit.txt"

0 commit comments

Comments
 (0)