Skip to content

Commit 0795e55

Browse files
authored
[oidc] Normalize GitHub environment claim (#13576)
* Add a failing test * Normalize GitHub's `environment` claim
1 parent 826811e commit 0795e55

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

tests/unit/oidc/test_utils.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ def test_find_publisher_by_issuer_bad_issuer_url():
3434
(None, uuid.UUID("aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa")),
3535
("some_other_environment", uuid.UUID("aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa")),
3636
("some_environment", uuid.UUID("bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb")),
37+
("sOmE_eNvIrOnMeNt", uuid.UUID("bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb")),
3738
],
3839
)
3940
def test_find_publisher_by_issuer_github(db_request, environment, expected_id):

warehouse/oidc/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def find_publisher_by_issuer(session, issuer_url, signed_claims, *, pending=Fals
5757
repository_name=repository_name,
5858
repository_owner=repository_owner,
5959
repository_owner_id=signed_claims["repository_owner_id"],
60-
environment=environment,
60+
environment=environment.lower(),
6161
)
6262
.filter(
6363
literal(workflow_ref).like(

0 commit comments

Comments
 (0)