Use underscores in param names

Author: di

tests/unit/manage/test_views.py

@@ -232,7 +232,7 @@ def test_delete_project_release(self, monkeypatch):
             project=pretend.stub(name='foobar'),
         )
         request = pretend.stub(
-            POST={'confirm-version': release.version},
+            POST={'confirm_version': release.version},
             method="POST",
             db=pretend.stub(
                 delete=pretend.call_recorder(lambda a: None),
@@ -286,7 +286,7 @@ def test_delete_project_release_no_confirm(self):
             project=pretend.stub(name='foobar'),
         )
         request = pretend.stub(
-            POST={'confirm-version': ''},
+            POST={'confirm_version': ''},
             method="POST",
             db=pretend.stub(delete=pretend.call_recorder(lambda a: None)),
             route_path=pretend.call_recorder(lambda *a, **kw: '/the-redirect'),
@@ -321,7 +321,7 @@ def test_delete_project_release_bad_confirm(self):
             project=pretend.stub(name='foobar'),
         )
         request = pretend.stub(
-            POST={'confirm-version': 'invalid'},
+            POST={'confirm_version': 'invalid'},
             method="POST",
             db=pretend.stub(delete=pretend.call_recorder(lambda a: None)),
             route_path=pretend.call_recorder(lambda *a, **kw: '/the-redirect'),

warehouse/manage/views.py

@@ -133,10 +133,10 @@ def manage_project_release(self):
 
     @view_config(
         request_method="POST",
-        request_param=["confirm-version"]
+        request_param=["confirm_version"]
     )
     def delete_project_release(self):
-        version = self.request.POST.get('confirm-version')
+        version = self.request.POST.get('confirm_version')
         if not version:
             self.request.session.flash(
                 "Must confirm the request.", queue='error'

warehouse/templates/manage/release.html

@@ -123,8 +123,8 @@ <h3 class="modal__title">Delete Release {{ release.version }}?</h3>
             <p>Warning: This action cannot be undone!</p>
           </div>
           <p>Confirm the release version to continue.</p>
-          <label for="confirm-version">Release version</label>
-          <input name="confirm-version" type="text" placeholder="Confirm version" autocomplete="off" autocorrect="off" autocapitalize="off">
+          <label for="confirm_version">Release version</label>
+          <input name="confirm_version" type="text" placeholder="Confirm version" autocomplete="off" autocorrect="off" autocapitalize="off">
         </div>
         <div class="modal__footer">
           <a href="#modal-close" class="button modal__action">Cancel</a>