Skip to content

Commit 674a185

Browse files
authored
trusted publishing: repo owner in emails (#13753)
* trusted publishing: repo owner in emails Signed-off-by: William Woodruff <[email protected]> * `make translations` Signed-off-by: William Woodruff <[email protected]> --------- Signed-off-by: William Woodruff <[email protected]>
1 parent 95f89b3 commit 674a185

File tree

7 files changed

+38
-28
lines changed

7 files changed

+38
-28
lines changed

tests/unit/email/test_init.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5800,6 +5800,7 @@ def test_trusted_publisher_emails(
58005800
project_name = "test_project"
58015801
fakepublisher = pretend.stub(
58025802
publisher_name="fakepublisher",
5803+
repository_owner="fakeowner",
58035804
repository_name="fakerepository",
58045805
environment="fakeenvironment",
58055806
)
@@ -5820,7 +5821,8 @@ def test_trusted_publisher_emails(
58205821
"project_name": project_name,
58215822
"publisher_name": "fakepublisher",
58225823
"publisher_workflow": "fakespecifier",
5823-
"publisher_repository": "fakerepository",
5824+
"publisher_repository_owner": "fakeowner",
5825+
"publisher_repository_name": "fakerepository",
58245826
"publisher_environment": "fakeenvironment",
58255827
}
58265828
subject_renderer.assert_()

warehouse/email/__init__.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -994,7 +994,8 @@ def send_trusted_publisher_added_email(request, user, project_name, publisher):
994994
"project_name": project_name,
995995
"publisher_name": publisher.publisher_name,
996996
"publisher_workflow": str(publisher),
997-
"publisher_repository": publisher.repository_name,
997+
"publisher_repository_owner": publisher.repository_owner,
998+
"publisher_repository_name": publisher.repository_name,
998999
"publisher_environment": publisher.environment,
9991000
}
10001001

@@ -1007,7 +1008,8 @@ def send_trusted_publisher_removed_email(request, user, project_name, publisher)
10071008
"project_name": project_name,
10081009
"publisher_name": publisher.publisher_name,
10091010
"publisher_workflow": str(publisher),
1010-
"publisher_repository": publisher.repository_name,
1011+
"publisher_repository_owner": publisher.repository_owner,
1012+
"publisher_repository_name": publisher.repository_name,
10111013
"publisher_environment": publisher.environment,
10121014
}
10131015

warehouse/locale/messages.pot

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2370,25 +2370,42 @@ msgstr ""
23702370

23712371
#: warehouse/templates/email/trusted-publisher-added/body.html:32
23722372
#: warehouse/templates/email/trusted-publisher-removed/body.html:30
2373+
#: warehouse/templates/includes/packaging/project-data.html:117
2374+
#: warehouse/templates/manage/account/publishing.html:139
2375+
#: warehouse/templates/manage/organization/roles.html:53
2376+
#: warehouse/templates/manage/organization/roles.html:172
2377+
#: warehouse/templates/manage/organizations.html:89
2378+
#: warehouse/templates/manage/project/publishing.html:76
2379+
#: warehouse/templates/manage/project/roles.html:50
2380+
#: warehouse/templates/manage/project/roles.html:85
2381+
#: warehouse/templates/manage/project/roles.html:115
2382+
#: warehouse/templates/manage/project/roles.html:127
2383+
#: warehouse/templates/manage/project/roles.html:172
2384+
#: warehouse/templates/manage/project/roles.html:184
2385+
msgid "Owner"
2386+
msgstr ""
2387+
2388+
#: warehouse/templates/email/trusted-publisher-added/body.html:33
2389+
#: warehouse/templates/email/trusted-publisher-removed/body.html:31
23732390
#: warehouse/templates/manage/account/publishing.html:76
23742391
#: warehouse/templates/manage/project/publishing.html:45
23752392
msgid "Repository"
23762393
msgstr ""
23772394

2378-
#: warehouse/templates/email/trusted-publisher-added/body.html:34
2379-
#: warehouse/templates/email/trusted-publisher-removed/body.html:32
2395+
#: warehouse/templates/email/trusted-publisher-added/body.html:35
2396+
#: warehouse/templates/email/trusted-publisher-removed/body.html:33
23802397
msgid "Environment"
23812398
msgstr ""
23822399

2383-
#: warehouse/templates/email/trusted-publisher-added/body.html:40
2400+
#: warehouse/templates/email/trusted-publisher-added/body.html:41
23842401
msgid ""
23852402
"If you did not make this change and you think it was made maliciously, "
23862403
"you can remove it from the project via the \"Publishing\" tab on the "
23872404
"project's page."
23882405
msgstr ""
23892406

2390-
#: warehouse/templates/email/trusted-publisher-added/body.html:47
2391-
#: warehouse/templates/email/trusted-publisher-removed/body.html:45
2407+
#: warehouse/templates/email/trusted-publisher-added/body.html:48
2408+
#: warehouse/templates/email/trusted-publisher-removed/body.html:46
23922409
#, python-format
23932410
msgid ""
23942411
"If you are unable to revert the change and need to do so, you can email "
@@ -2403,7 +2420,7 @@ msgid ""
24032420
"from a project (<strong>%(project_name)s</strong>) that you manage."
24042421
msgstr ""
24052422

2406-
#: warehouse/templates/email/trusted-publisher-removed/body.html:38
2423+
#: warehouse/templates/email/trusted-publisher-removed/body.html:39
24072424
msgid ""
24082425
"If you did not make this change and you think it was made in error, you "
24092426
"can check the \"Security history\" tab on the project's page."
@@ -2784,21 +2801,6 @@ msgstr ""
27842801
msgid "Requires:"
27852802
msgstr ""
27862803

2787-
#: warehouse/templates/includes/packaging/project-data.html:117
2788-
#: warehouse/templates/manage/account/publishing.html:139
2789-
#: warehouse/templates/manage/organization/roles.html:53
2790-
#: warehouse/templates/manage/organization/roles.html:172
2791-
#: warehouse/templates/manage/organizations.html:89
2792-
#: warehouse/templates/manage/project/publishing.html:76
2793-
#: warehouse/templates/manage/project/roles.html:50
2794-
#: warehouse/templates/manage/project/roles.html:85
2795-
#: warehouse/templates/manage/project/roles.html:115
2796-
#: warehouse/templates/manage/project/roles.html:127
2797-
#: warehouse/templates/manage/project/roles.html:172
2798-
#: warehouse/templates/manage/project/roles.html:184
2799-
msgid "Owner"
2800-
msgstr ""
2801-
28022804
#: warehouse/templates/includes/packaging/project-data.html:130
28032805
msgid "Maintainers"
28042806
msgstr ""

warehouse/templates/email/trusted-publisher-added/body.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@
2929
<ul>
3030
<li>{% trans %}Publisher name{% endtrans %}: {{ publisher_name }}</li>
3131
<li>{% trans %}Workflow{% endtrans %}: {{ publisher_workflow }}</li>
32-
<li>{% trans %}Repository{% endtrans %}: {{ publisher_repository }}</li>
32+
<li>{% trans %}Owner{% endtrans %}: {{ publisher_repository_owner }}</li>
33+
<li>{% trans %}Repository{% endtrans %}: {{ publisher_repository_name }}</li>
3334
{% if publisher_environment %}
3435
<li>{% trans %}Environment{% endtrans %}: {{ publisher_environment }}</li>
3536
{% endif %}

warehouse/templates/email/trusted-publisher-added/body.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ users and can create project releases automatically.
2424

2525
* {% trans %}Publisher{% endtrans %}: {{ publisher_name }}
2626
* {% trans %}Workflow{% endtrans %}: {{ publisher_workflow }}
27-
* {% trans %}Repository{% endtrans %}: {{ publisher_repository }}
27+
* {% trans %}Owner{% endtrans %}: {{ publisher_repository_owner }}
28+
* {% trans %}Repository{% endtrans %}: {{ publisher_repository_name }}
2829
{%- if publisher_environment %}
2930
* {% trans %}Environment{% endtrans %}: {{ publisher_environment }}
3031
{%- endif %}

warehouse/templates/email/trusted-publisher-removed/body.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
<ul>
2828
<li>{% trans %}Publisher name{% endtrans %}: {{ publisher_name }}</li>
2929
<li>{% trans %}Workflow{% endtrans %}: {{ publisher_workflow }}</li>
30-
<li>{% trans %}Repository{% endtrans %}: {{ publisher_repository }}</li>
30+
<li>{% trans %}Owner{% endtrans %}: {{ publisher_repository_owner }}</li>
31+
<li>{% trans %}Repository{% endtrans %}: {{ publisher_repository_name }}</li>
3132
{% if publisher_environment %}
3233
<li>{% trans %}Environment{% endtrans %}: {{ publisher_environment }}</li>
3334
{% endif %}

warehouse/templates/email/trusted-publisher-removed/body.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ PyPI user {{ username }} has removed a trusted publisher from a project
2323

2424
* {% trans %}Publisher{% endtrans %}: {{ publisher_name }}
2525
* {% trans %}Workflow{% endtrans %}: {{ publisher_workflow }}
26-
* {% trans %}Repository{% endtrans %}: {{ publisher_repository }}
26+
* {% trans %}Owner{% endtrans %}: {{ publisher_repository_owner }}
27+
* {% trans %}Repository{% endtrans %}: {{ publisher_repository_name }}
2728
{%- if publisher_environment %}
2829
* {% trans %}Environment{% endtrans %}: {{ publisher_environment }}
2930
{% endif %}

0 commit comments

Comments
 (0)