Activate user on email verification

Author: di

tests/unit/accounts/test_views.py

@@ -699,7 +699,7 @@ def test_reset_password_password_date_changed(self, pyramid_request):
 class TestVerifyEmail:
 
     def test_verify_email(self, db_request, user_service, token_service):
-        user = UserFactory()
+        user = UserFactory(is_active=False)
         email = EmailFactory(user=user, verified=False)
         db_request.user = user
         db_request.GET.update({"token": "RANDOM_KEY"})
@@ -721,6 +721,7 @@ def test_verify_email(self, db_request, user_service, token_service):
 
         db_request.db.flush()
         assert email.verified
+        assert user.is_active
         assert isinstance(result, HTTPSeeOther)
         assert result.headers["Location"] == "/"
         assert db_request.route_path.calls == [pretend.call('manage.profile')]

warehouse/accounts/views.py

@@ -378,6 +378,7 @@ def _error(message):
         return _error("Email already verified")
 
     email.verified = True
+    request.user.is_active = True
 
     request.session.flash(
         f'Email address {email.email} verified.', queue='success'