Skip to content

Commit fa2c5f9

Browse files
ewjoachimdi
andcommitted
Remove intermediate function time_ms
Co-authored-by: Dustin Ingram <[email protected]>
1 parent ea6c28a commit fa2c5f9

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

tests/unit/test_tasks.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,8 @@ def test_creates_request(self, monkeypatch):
167167
assert obj.request.pyramid_env == pyramid_env
168168
assert request is pyramid_env["request"]
169169
assert isinstance(request.tm, transaction.TransactionManager)
170+
assert 1.5e12 < request.timings["new_request_start"] < 1e13
171+
assert request.remote_addr == "127.0.0.1"
170172

171173
def test_reuses_request(self):
172174
pyramid_env = {"request": pretend.stub()}

warehouse/tasks.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,6 @@ def _params_from_url(self, url, defaults):
4949
return params
5050

5151

52-
def time_ms():
53-
return time.time() * 1000
54-
55-
5652
class WarehouseTask(celery.Task):
5753
def __new__(cls, *args, **kwargs):
5854
obj = super().__new__(cls, *args, **kwargs)
@@ -95,7 +91,7 @@ def get_request(self):
9591
registry = self.app.pyramid_config.registry
9692
env = pyramid.scripting.prepare(registry=registry)
9793
env["request"].tm = transaction.TransactionManager(explicit=True)
98-
env["request"].timings = {"new_request_start": time_ms()}
94+
env["request"].timings = {"new_request_start": time.time() * 1000}
9995
env["request"].remote_addr = "127.0.0.1"
10096
self.request.update(pyramid_env=env)
10197

0 commit comments

Comments
 (0)