Skip to content

AuthZ: remove deprecated Pyramid 1.0 policies #13690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
woodruffw opened this issue May 17, 2023 · 0 comments · Fixed by #13849
Closed

AuthZ: remove deprecated Pyramid 1.0 policies #13690

woodruffw opened this issue May 17, 2023 · 0 comments · Fixed by #13849
Assignees
@woodruffw
Labels
security Security-related issues and pull requests

Comments

@woodruffw
Copy link
Member

Warehouse currently uses Pyramid 2.0 style "security policies" at the top level (via warehouse.utils.security_policy.MultiSecurityPolicy). However, these are (currently) just a thin wrapper for a few 1.0-style authorization policies:

  • TwoFactorAuthorizationPolicy
  • MacaroonAuthorizationPolicy

These should be merged into their corresponding security policies, both simplifying the codebase and removing a handful of deprecated API sites.

(Assigning myself for triage, but will reassign.)
@woodruffw woodruffw self-assigned this May 17, 2023
@miketheman miketheman added the security Security-related issues and pull requests label May 19, 2023
@tnytown tnytown mentioned this issue May 25, 2023
Closed
@dstufft dstufft mentioned this issue Jun 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
security Security-related issues and pull requests
Projects
None yet
Milestone
No milestone
2 participants
@miketheman @woodruffw