Skip to content

Clickable elements in Project sidebar are easy to "mis click" #16743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ewdurbin opened this issue Sep 18, 2024 · 6 comments · Fixed by #16746
Closed

Clickable elements in Project sidebar are easy to "mis click" #16743

ewdurbin opened this issue Sep 18, 2024 · 6 comments · Fixed by #16746
Labels
bug 🐛 requires triaging maintainers need to do initial inspection of issue

Comments

@ewdurbin
Copy link
Member

Describe the bug

Project URLs in the sidebar on pages like https://pypi.org/project/django-polymorphic/ are difficult to click due to overlapping hit boxes.

For instance, when cursoring up through the list attempting to click "Homepage" here, I accidentally hit "Download":

Screenshot 2024-09-18 at 2 26 36 PM

Additionally, non clickable things like "License" and tags act as clickable when scrolling over them:

Screenshot 2024-09-18 at 2 32 08 PM

Expected behavior

Links should be easy to click, things that are not links should not behave as links.

To Reproduce

Navigate to a project page and trial/inspect the elements to see how cursor behaves and which link is active.

My Platform

Noticed on Safari 18.0 on MacOS 15.0.

Additional context

May be related to #15737 or #16532.

@ewdurbin ewdurbin added requires triaging maintainers need to do initial inspection of issue bug 🐛 labels Sep 18, 2024
@di
Copy link
Member

di commented Sep 18, 2024

Looks like the "clickable"-ness is due to the span having the vertical-tabs__tab and vertical-tabs__tab--condensed classes, and the parent ul having the vertical-tabs__list class. Removing these will reintroduce the bullets as well, so we would need to suppress them to maintain the same view.

The spacing seems to be due to

which is overridding:

However this was done so the checkboxes display inline with the link, so an alternative method to do that will need to be found.

@di
Copy link
Member

di commented Sep 18, 2024

Also, it was noted that the checkmarks may be redundant given they are already within a "verified" section, so perhaps it makes the most sense to remove them.

@ewdurbin
Copy link
Member Author

I'm pretty sure the spacing/hitbox issue is just the removal of definite padding on a elements in #16532 and I can't understand why that occurred.

@di
Copy link
Member

di commented Sep 18, 2024

Here's what it looks like with display: inline removed and the checkboxes removed:

image

Seems like that's approximately what it originally looked like?

@di
Copy link
Member

di commented Sep 18, 2024

Here's what it looked like 4 years ago: https://web.archive.org/web/20200919103428/https://pypi.org/project/pytest-socket/

image

@ofek
Copy link
Contributor

ofek commented Sep 18, 2024

I'm in favor of removing the checkmarks since the entire section is under the verified header. I missed the documentation link and had to ask what the checkmarks meant because of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 requires triaging maintainers need to do initial inspection of issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants