Skip to content

Old wheels may have broken descriptions #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
di opened this issue Feb 27, 2018 · 5 comments
Closed

Old wheels may have broken descriptions #3084

di opened this issue Feb 27, 2018 · 5 comments

Comments

@di
Copy link
Member

di commented Feb 27, 2018

In #3058 we figured out that a wheel built with wheel==0.24.0 had a broken description when uploaded to Warehouse. Upgrading to wheel==0.30.0 fixed it.

If we have a way to determine what version of wheel the wheel was built with, we may want to warn the user in some way (from Warehouse? in twine?) that it could result in an incorrectly rendered description.

@di di added needs discussion a product management/policy issue maintainers and users should discuss developer experience Anything that improves the experience for Warehouse devs labels Feb 27, 2018
@dstufft
Copy link
Member

dstufft commented Feb 27, 2018

Look a *.dist-info/WHEEL, that should contain what was used to build it, but not sure if it includes version information or not.

@di
Copy link
Member Author

di commented Feb 27, 2018

Seems like maybe this issue belongs over at pypa/twine instead since we're not doing much introspection of the distributions.

@brainwane brainwane added requires triaging maintainers need to do initial inspection of issue and removed requires triaging maintainers need to do initial inspection of issue labels Mar 1, 2018
@brainwane
Copy link
Contributor

About how many projects do we currently have where the most recent release has a broken description because of this issue? I presume that's something I could figure out via Google BigQuery if I figured out how to use it.

@di
Copy link
Member Author

di commented Apr 2, 2018

I don't think it's possible via BigQuery, as Donald said, the version of wheel used to build the distribution is in the metadata, but we don't extract it or do any introspection of the file.

I haven't seen many reports about this, and there might not really be a good way to fix it, so this shouldn't be high-priority (folks should just update their wheel).

@brainwane brainwane added this to the 6. Post Legacy Shutdown milestone Apr 2, 2018
@brainwane brainwane added feature request and removed developer experience Anything that improves the experience for Warehouse devs needs discussion a product management/policy issue maintainers and users should discuss requires triaging maintainers need to do initial inspection of issue labels Apr 2, 2018
@di
Copy link
Member Author

di commented Mar 25, 2020

Closing this since we no longer allow uploads with invalid/broken descriptions, so the point is moot.

@di di closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants