Skip to content

Unnecessary purges on User model change #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
di opened this issue Mar 21, 2018 · 4 comments
Closed

Unnecessary purges on User model change #3336

di opened this issue Mar 21, 2018 · 4 comments

Comments

@di
Copy link
Member

di commented Mar 21, 2018

Currently right now any time the User model changes, we purge all the cache keys for that user's project.

This includes attribute changes that don't actually affect the project pages, like last_login, password etc.

We should filter out "purge-able" attribute changes and only issue purges when necessary. Said attributes include:

  • username
  • name
  • emails
@ewdurbin
Copy link
Member

ewdurbin commented Mar 22, 2018

it also issues an all-projects which purges /simple
* was looking at wrong log :)

@di
Copy link
Member Author

di commented Mar 22, 2018

Hmm, shouldn't be...

@ewdurbin
Copy link
Member

my bad, sneaky edited my original comment after checking logs more closely.

@brainwane brainwane added this to the 3: Publicize beta milestone Mar 22, 2018
@brainwane
Copy link
Contributor

Ernest mentioned we need this before launching beta, because otherwise it's so costly to serve users who have many projects each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants