Skip to content

(Fortunately) broken pytest_load_initial_conftests decorator #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkemmerling opened this issue Nov 3, 2014 · 6 comments
Closed

(Fortunately) broken pytest_load_initial_conftests decorator #24

mkemmerling opened this issue Nov 3, 2014 · 6 comments

Comments

@mkemmerling
Copy link

The @pytest.mark.try_last decorator of the pytest_load_initial_conftests hook has no effect, it should contain no underscore (see http://pytest.org/latest/example/markers.html#registering-markers).

But with respect to issue #19 (see also pytest-dev/pytest-django#175 and pytest-dev/pytest-django#186) I would propose to rather decorate the hook with the @pytest.mark.tryfirst decorator, if any.

@schlamar
Copy link
Contributor

schlamar commented Nov 4, 2014

Mhh, I have no clue how this could have happended.. Nothing except tryfirst makes sense here. #25

@mkemmerling
Copy link
Author

Thanks a lot for for the immediate fix!

@schlamar
Copy link
Contributor

schlamar commented Nov 6, 2014

I guess it does work for your case? I'd release a new version soon.

@mkemmerling
Copy link
Author

Great. And yes, it works perfectly.

@schlamar schlamar closed this as completed Nov 6, 2014
@schlamar
Copy link
Contributor

schlamar commented Nov 6, 2014

Just released 1.8.1

@paulcollinsiii
Copy link

thank you guys. I just ran into this error last night and to see it fixed this afternoon is freaking great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants