Skip to content

Allow breaking the list of results in pages #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost opened this issue Mar 26, 2016 · 4 comments
Open

Allow breaking the list of results in pages #39

ghost opened this issue Mar 26, 2016 · 4 comments
Labels
enhancement This issue/PR relates to a feature request.

Comments

@ghost
Copy link

ghost commented Mar 26, 2016

Useful when you have thousands of tests and the browser struggles to open them all.

@davehunt davehunt added enhancement This issue/PR relates to a feature request. outreachy labels Mar 29, 2016
@davehunt
Copy link
Collaborator

This sounds like a nice enhancement. We could have a sensible default number of results and beyond that introduce pagination. My only concern is how filtering (#38) and sorting would be expected to work as these will be limited to the results on the page. It could simply be a not that's added to the page when pagination is present.

@davidedelvento
Copy link

I think that instead of just spitting the result in multiple "dumb" pages with a fixed number of tests in each (nobody said so, but it "felt" like the natural implementation of this enhancement), it would be nice to have the HTML pages structured in a hierarchy.

In the common py.test use case, there will be test_something.py files in different directories. Each directory (or maybe each file, possibly with a command line flag or configuration option to decide which one) should be its own html file.

Bonus point: the top-level html report summarizes everything, with a single line for each directory (file) stating how many run/pass/fail/etc and a link to the other HTML file with more details.

@davehunt
Copy link
Collaborator

davehunt commented Jun 3, 2016

In the common py.test use case, there will be test_something.py files in different directories. Each directory (or maybe each file, possibly with a command line flag or configuration option to decide which one) should be its own html file.

I like this idea better than creating pagination. It's possible there will still be thousands of rows though if the tests are parameterised. Would splitting HTML files by module/class/function work for your needs @gmagno?

Bonus point: the top-level html report summarizes everything, with a single line for each directory (file) stating how many run/pass/fail/etc and a link to the other HTML file with more details.

This is a great idea!

@ghost
Copy link
Author

ghost commented Jun 3, 2016

I like this idea better than creating pagination. It's possible there will still be thousands of rows though if the tests are parameterised. Would splitting HTML files by module/class/function work for your needs @gmagno?

That seems reasonable.

@davehunt davehunt removed the outreachy label Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Development

No branches or pull requests

2 participants