From fea4eb3f3ddf733fb6bf95e34061cb124332c5fb Mon Sep 17 00:00:00 2001 From: Christian Sandberg Date: Tue, 3 Mar 2020 19:52:27 +0100 Subject: [PATCH] Fix image missing when using Base64 content --- pytest_html/plugin.py | 7 ++++++- testing/test_pytest_html.py | 4 ++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/pytest_html/plugin.py b/pytest_html/plugin.py index 8cd72b63..45a4f500 100644 --- a/pytest_html/plugin.py +++ b/pytest_html/plugin.py @@ -319,7 +319,12 @@ def _make_media_html_div( href = src = self.create_asset( content, extra_index, test_index, extra.get("extension"), "wb" ) - html_div = html.a(class_=base_extra_class, target="_blank", href=href) + html_div = html.a( + raw(base_extra_string.format(src)), + class_=base_extra_class, + target="_blank", + href=href, + ) return html_div def _append_image(self, extra, extra_index, test_index): diff --git a/testing/test_pytest_html.py b/testing/test_pytest_html.py index f19fee0f..0aa2f421 100644 --- a/testing/test_pytest_html.py +++ b/testing/test_pytest_html.py @@ -510,7 +510,9 @@ def pytest_runtest_makereport(item, call): assert result.ret == 0 src = f"assets/test_extra_image_separated.py__test_pass_0_0.{file_extension}" link = f'' + img = f'' assert link in html + assert img in html assert os.path.exists(src) @pytest.mark.parametrize( @@ -544,8 +546,10 @@ def test_fail(): asset_name = "test_extra_image_separated_rerun.py__test_fail" src = f"assets/{asset_name}_0_{i}.{file_extension}" link = f'' + img = f'' assert result.ret assert link in html + assert img in html assert os.path.exists(src) @pytest.mark.parametrize("src_type", ["https://", "file://", "image.png"])