Fix issue where pytest_runtest_makereport was hiding exceptions from other plugins

Fix #98

Author: nicoddemus

CHANGELOG.md

@@ -1,3 +1,11 @@
+# 1.7.1.dev #
+
+- Fixed internal error when interacting with other plugins that raise an error,
+  hiding the original exception (#98). Thanks @The-Compiler for the PR!
+  
+- Now `pytest-qt` is properly tested with PyQt5 on Travis-CI. Many thanks
+  to @The-Compiler for the PR!
+
 # 1.7.0 #
 
 - `PYTEST_QT_API` can now be set to `pyqt4v2` in order to use version 2 of the 

pytestqt/logging.py

@@ -40,13 +40,12 @@ def pytest_runtest_setup(self, item):
     @pytest.mark.hookwrapper
     def pytest_runtest_makereport(self, item, call):
         """Add captured Qt messages to test item report if the call failed."""
-
         outcome = yield
         if not hasattr(item, 'qt_log_capture'):
             return
 
         if call.when == 'call':
-            report = outcome.result
+            report = outcome.get_result()
 
             m = item.get_marker('qt_log_level_fail')
             if m:

tests/test_logging.py

@@ -484,3 +484,32 @@ def test_foo(request):
         '*None:None:None:*',
         '* QtWarningMsg: WARNING message*',
     ])
+
+
+def test_logging_broken_makereport(testdir):
+    """
+    Make sure logging's makereport hookwrapper doesn't hide exceptions.
+
+    See https://github.com/pytest-dev/pytest-qt/issues/98
+
+    :type testdir: _pytest.pytester.TmpTestdir
+    """
+    testdir.makepyfile(conftest="""
+        import pytest
+
+        @pytest.mark.hookwrapper(tryfirst=True)
+        def pytest_runtest_makereport(call):
+            if call.when == 'call':
+                raise Exception("This should not be hidden")
+            yield
+    """)
+    p = testdir.makepyfile(
+        """
+        def test_foo():
+            pass
+        """
+    )
+    res = testdir.runpytest_subprocess(p)
+    res.stdout.fnmatch_lines([
+        '*This should not be hidden*',
+    ])