Skip to content

Commit 2e48573

Browse files
committed
Make "-nX" and "--dist=loadscope" work properly together
1 parent 43f7dbe commit 2e48573

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

testing/acceptance_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -727,7 +727,7 @@ def test(i):
727727
test_a=test_file,
728728
test_b=test_file,
729729
)
730-
result = testdir.runpytest('--tx=2*popen', '--dist=loadscope', '-v')
730+
result = testdir.runpytest('-n2', '--dist=loadscope', '-v')
731731
assert get_workers_and_test_count_by_prefix('test_a.py::test', result.outlines) == {'gw0': 10}
732732
assert get_workers_and_test_count_by_prefix('test_b.py::test', result.outlines) == {'gw1': 10}
733733

@@ -744,7 +744,7 @@ class TestB:
744744
def test(self, i):
745745
pass
746746
""")
747-
result = testdir.runpytest('--tx=2*popen', '--dist=loadscope', '-v')
747+
result = testdir.runpytest('-n2', '--dist=loadscope', '-v')
748748
assert get_workers_and_test_count_by_prefix('test_a.py::TestA', result.outlines) == {'gw0': 10}
749749
assert get_workers_and_test_count_by_prefix('test_a.py::TestB', result.outlines) == {'gw1': 10}
750750

xdist/plugin.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ def pytest_configure(config):
9898
@pytest.mark.tryfirst
9999
def pytest_cmdline_main(config):
100100
if config.option.numprocesses:
101-
config.option.dist = "load"
101+
if not config.option.dist:
102+
config.option.dist = "load"
102103
config.option.tx = ['popen'] * config.option.numprocesses
103104
if config.option.distload:
104105
config.option.dist = "load"

0 commit comments

Comments
 (0)