Workaround for cmdexec bug on Windows

This bug fails the entire pytest suite when executed with the
--lsof option in Python 2 on Windows.

Author: nicoddemus

_pytest/pytester.py

@@ -74,7 +74,10 @@ def isopen(line):
     def matching_platform(self):
         try:
             py.process.cmdexec("lsof -v")
-        except py.process.cmdexec.Error:
+        except (py.process.cmdexec.Error, UnicodeDecodeError):
+            # cmdexec may raise UnicodeDecodeError on Windows systems
+            # with locale other than english:
+            # https://bitbucket.org/pytest-dev/py/issues/66
             return False
         else:
             return True

testing/test_capture.py

@@ -650,7 +650,7 @@ def lsof_check():
     try:
         out = py.process.cmdexec("lsof -p %d" % pid)
     except (py.process.cmdexec.Error, UnicodeDecodeError):
-        # about UnicodeDecodeError, see note on conftest.py 
+        # about UnicodeDecodeError, see note on pytester
         pytest.skip("could not run 'lsof'")
     yield
     out2 = py.process.cmdexec("lsof -p %d" % pid)