Skip to content

Commit e229a27

Browse files
committed
using @pytest.mark.parametrize instead of calling one test many times from another as suggested by @nicoddemus in pr #1754
1 parent ec7695e commit e229a27

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

testing/test_doctest.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -804,7 +804,8 @@ def foo():
804804
""")
805805
return testdir.runpytest("--doctest-modules", "--doctest-report", format)
806806

807-
def test_doctest_report_udiff(self, testdir, format='udiff'):
807+
@pytest.mark.parametrize('format', ['udiff', 'UDIFF', 'uDiFf'])
808+
def test_doctest_report_udiff(self, testdir, format):
808809
result = self._run_doctest_report(testdir, format)
809810
result.stdout.fnmatch_lines([
810811
' 0 1 4',
@@ -855,10 +856,6 @@ def test_doctest_report_none_or_only_first_failure(self, testdir):
855856
' 2 3 6',
856857
])
857858

858-
def test_doctest_report_case_insensitive(self, testdir):
859-
for format in 'udiff', 'UDIFF', 'uDiFf':
860-
self.test_doctest_report_udiff(testdir, format)
861-
862859
def test_doctest_report_invalid(self, testdir):
863860
result = self._run_doctest_report(testdir, 'obviously_invalid_format')
864861
result.stderr.fnmatch_lines([

0 commit comments

Comments
 (0)