Merge pull request #4229 from nicoddemus/fix-warning-location

Show node that originated a warning in the warnings summary

Author: RonnyPfannschmidt

changelog/4221.bugfix.rst

@@ -0,0 +1 @@
+Fix bug where the warning summary at the end of the test session was not showing the test where the warning was originated.

src/_pytest/terminal.py

@@ -725,11 +725,10 @@ def summary_warnings(self):
                 # legacy warnings show their location explicitly, while standard warnings look better without
                 # it because the location is already formatted into the message
                 warning_records = list(warning_records)
-                is_legacy = warning_records[0].legacy
-                if location and is_legacy:
+                if location:
                     self._tw.line(str(location))
                 for w in warning_records:
-                    if is_legacy:
+                    if location:
                         lines = w.message.splitlines()
                         indented = "\n".join("  " + x for x in lines)
                         message = indented.rstrip()

testing/test_warnings.py

@@ -48,6 +48,7 @@ def test_normal_flow(testdir, pyfile_with_warnings):
     result.stdout.fnmatch_lines(
         [
             "*== %s ==*" % WARNINGS_SUMMARY_HEADER,
+            "test_normal_flow.py::test_func",
             "*normal_flow_module.py:3: UserWarning: user warning",
             '*  warnings.warn(UserWarning("user warning"))',
             "*normal_flow_module.py:4: RuntimeWarning: runtime warning",
@@ -369,8 +370,8 @@ def test_foo():
     result.stdout.fnmatch_lines(
         [
             "*== %s ==*" % WARNINGS_SUMMARY_HEADER,
-            "*collection_warnings.py:3: UserWarning: collection warning",
-            '  warnings.warn(UserWarning("collection warning"))',
+            "  *collection_warnings.py:3: UserWarning: collection warning",
+            '    warnings.warn(UserWarning("collection warning"))',
             "* 1 passed, 1 warnings*",
         ]
     )