Skip to content

adapt the python 3.7 ast additions/changes #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RonnyPfannschmidt opened this issue Oct 6, 2017 · 5 comments · Fixed by #2870
Closed

adapt the python 3.7 ast additions/changes #2818

RonnyPfannschmidt opened this issue Oct 6, 2017 · 5 comments · Fixed by #2870
Labels
status: help wanted developers would like help from experts on this topic topic: rewrite related to the assertion rewrite mechanism type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: feature-branch new feature or API change, should be merged into features branch

Comments

@RonnyPfannschmidt
Copy link
Member

python3.7 did away with pyo and it did add/change some details about the ast

this causes the current failures and should be reasonably fixabl
@RonnyPfannschmidt RonnyPfannschmidt added Hacktoberfest status: help wanted developers would like help from experts on this topic topic: rewrite related to the assertion rewrite mechanism type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: feature-branch new feature or API change, should be merged into features branch labels Oct 6, 2017
@tomviner tomviner mentioned this issue Oct 18, 2017
Merged
@tomviner
Copy link
Contributor

python3.7 did away with pyo

wasn't that in 3.5? https://www.python.org/dev/peps/pep-0488/

@RonnyPfannschmidt
Copy link
Member Author

@tomviner thanks correcting - i misinterpreted the pr output back then

@Perlence
Copy link
Contributor

Alpha versions of Python 3.7.0 don't respect PYTHONDONTWRITEBYTECODE https://bugs.python.org/issue31845
This makes test_dont_write_bytecode fail.

@Perlence
Copy link
Contributor

Looks like PYTHONOPTIMIZE has no effect either.

@nicoddemus
Copy link
Member

Thanks @Perlence for finding this.

@Perlence Perlence mentioned this issue Oct 25, 2017
Merged
@pytestbot pytestbot mentioned this issue Jul 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted developers would like help from experts on this topic topic: rewrite related to the assertion rewrite mechanism type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: feature-branch new feature or API change, should be merged into features branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapt the Python 3.7 AST changes Perlence/pytest
4 participants
@RonnyPfannschmidt @tomviner @Perlence @nicoddemus