Skip to content

empty parameterset - transtion to failure by default #3979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
RonnyPfannschmidt opened this issue Sep 13, 2018 · 1 comment
Open
2 tasks

empty parameterset - transtion to failure by default #3979

RonnyPfannschmidt opened this issue Sep 13, 2018 · 1 comment
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: deprecation feature that will be removed in the future type: feature-branch new feature or API change, should be merged into features branch

Comments

@RonnyPfannschmidt
Copy link
Member

followup to #3970

when the empty parameterset idea was introduced, it was pretty bad, it still is and should actually turn bac kto a failure by default

however to facilitate that we need

  • a transition plan with a warning
  • a sensible mechanism to override the global option per parametrize, so people an make local informed choices
@RonnyPfannschmidt RonnyPfannschmidt added type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: feature-branch new feature or API change, should be merged into features branch type: deprecation feature that will be removed in the future labels Sep 13, 2018
@nicoddemus
Copy link
Member

nicoddemus commented Sep 13, 2018

Thanks for creating this follow up @RonnyPfannschmidt.

I think we should emit the warning if we encounter an empty parameter set and the empty_parameter_set_mark is not set, warning that the default value will change and users should update their pytest.ini file if they like the skip behavior.

After two releases we just change the defaults, people will have seen the warning now and update their settings if they care.

Not sure we need to add the ability to change the ini setting from each parametrize though, as we don't have that option now. But if we want to add it should be simple, an option to parametrize which can be used to override the ini setting: skip, xfail and fail_at_parametrize, unless if I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: backward compatibility might present some backward compatibility issues which should be carefully noted in the changelog type: deprecation feature that will be removed in the future type: feature-branch new feature or API change, should be merged into features branch
Projects
None yet
Development

No branches or pull requests

2 participants