_node_cache in #2283 may sometimes cause tests to get lost

[Ms2ger]

Ref: web-platform-tests/wpt#13119

The cache is keyed on (type(x), x.fspath), and in our case, we ended with the exact same key for every test.

We are running pytest -vv tests (through tox) in resources/test, where tests is the subdirectory that contains our HTML test files. Abridged code is:

def pytest_collect_file(path, parent):
    return HTMLItem(str(path), parent)

class HTMLItem(pytest.Item, pytest.Collector):
    def __init__(self, filename, parent):
        name = extract_name(filename)
        super(HTMLItem, self).__init__(name, parent)

where parent is <Session 'test'>. The Node constructor initializes fspath to local('/web-platform-tests/resources/test')) for each of the tests, and we end up running only the first one.

Please let me know if I can provide more information.

#2283

[nicoddemus]

Thanks @Ms2ger for the report!

[nicoddemus]

cc @jonozzz, I'm not sure how our cache should handle multiple nodes with the same key. Any suggestions?

[RonnyPfannschmidt]

pytest should fail hard - those are file items that dont reffer to the owning file

[bluetech]

There have been quite a few changes around this code, especially for pytest 8.0.0 (you can try it with pip install pytest==8.0.0rc1), I think this is probably fixed. Let us know if not.