Skip to content

reorganize-docs branch status #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicoddemus opened this issue Oct 12, 2018 · 9 comments
Closed

reorganize-docs branch status #4120

nicoddemus opened this issue Oct 12, 2018 · 9 comments
Labels
type: docs documentation improvement, missing or needing clarification type: infrastructure improvement to development/releases/CI structure

Comments

@nicoddemus
Copy link
Member

https://github.com/pytest-dev/pytest/commits/reorganize-docs is the branch that @obestwalter, @pfctdayelise, and @hackebrot worked during our 2016 sprint. This has been sitting there for two years now, and unfortunately may cause confusion because the docs are online and outdated (#4115 (comment)).

@obestwalter, @pfctdayelise, and @hackebrot, would you like to keep the branch or should we delete it? I'm not sure how useful the branch is, given that it is probably riddled with conflicts by now...

@nicoddemus nicoddemus added type: docs documentation improvement, missing or needing clarification type: infrastructure improvement to development/releases/CI structure labels Oct 12, 2018
@blueyed
Copy link
Contributor

blueyed commented Oct 13, 2018

given that it is probably riddled with conflicts by now...

Just two files when merging master:

CONFLICT (content): Merge conflict in doc/en/skipping.rst
CONFLICT (content): Merge conflict in AUTHORS

@nicoddemus
Copy link
Member Author

Oh I'm surprised, hehehe!

@pfctdayelise
Copy link
Contributor

I would say delete it 😑

@Zac-HD
Copy link
Member

Zac-HD commented Oct 19, 2018

From a quick skim over the diff, it's mostly placeholder pages for the reorganization and the completed pages all cover content that has since been expanded (marks, xfail, skipping). I'd delete the branch.

@hackebrot
Copy link
Member

I copied the branch to my fork. Go ahead and delete it @nicoddemus! 🗑

@nicoddemus
Copy link
Member Author

Deleted then! As long as it is saved somewhere we can always get it back if we want to.

Thanks everyone! 🤗

@kini
Copy link

kini commented Jun 14, 2021

I found some pytest documentation pages on google which had "reorganize-docs" in their URLs (e.g. https://docs.pytest.org/en/reorganize-docs/new-docs/user/directory_structure.html). I couldn't find any explanation internal to the pages themselves as to why they exist, whether they're relevant / up to date, etc., so I went searching on github, which led me to this ticket.

Do those pages come from the branch being discussed in this github issue? If so, since the branch has been deleted, should the pages also be removed from the website?

@The-Compiler
Copy link
Member

We've long deleted them, unfortunately they're still around somehow, and even a redirect didn't help. I'll get in contact with ReadTheDocs support to see if they can do something about it.

@The-Compiler
Copy link
Member

FYI I have some news on this, see #8098.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs documentation improvement, missing or needing clarification type: infrastructure improvement to development/releases/CI structure
Projects
None yet
Development

No branches or pull requests

7 participants