Skip to content

tmp_path_factory not mentioned in changelog #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaraco opened this issue Nov 5, 2019 · 5 comments · Fixed by #6204
Closed

tmp_path_factory not mentioned in changelog #6135

jaraco opened this issue Nov 5, 2019 · 5 comments · Fixed by #6204
Labels
good first issue easy issue that is friendly to new contributor type: docs documentation improvement, missing or needing clarification

Comments

@jaraco
Copy link
Contributor

jaraco commented Nov 5, 2019

When was it added? Maybe consider updating the changelog and/or documentation so someone using this feature might know what is the minimum version required to include it.
@The-Compiler
Copy link
Member

It was added when tmp_path was added in 3.9.0 (which is mentioned in the changelog). The documentation for tmp_path_factory used to mention that, but given that it's more than two major releases ago, it was removed in 9c5da9c.

@Zac-HD Zac-HD added good first issue easy issue that is friendly to new contributor type: docs documentation improvement, missing or needing clarification labels Nov 5, 2019
@Zac-HD
Copy link
Member

Zac-HD commented Nov 5, 2019

Let's just add a changelog entry then, so you can grep for it there if the date is important to you.

Tagged as "easy" because I think this would be a good first PR for a new contributor 😄

@TH3CHARLie
Copy link
Contributor

@Zac-HD I'd like to take it

@Zac-HD
Copy link
Member

Zac-HD commented Nov 16, 2019

Go for it! Happy to review if you tag me in the PR 😁

@TH3CHARLie TH3CHARLie mentioned this issue Nov 16, 2019
Merged
@jaraco
Copy link
Contributor Author

jaraco commented Nov 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue easy issue that is friendly to new contributor type: docs documentation improvement, missing or needing clarification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changelog: #3985 also introduce tmp_path_factory
4 participants
@jaraco @The-Compiler @Zac-HD @TH3CHARLie