Skip to content

Error in example documentation for fixtures #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pytestbot opened this issue Dec 1, 2014 · 3 comments
Closed

Error in example documentation for fixtures #636

pytestbot opened this issue Dec 1, 2014 · 3 comments
Labels
type: bug problem that needs to be addressed type: docs documentation improvement, missing or needing clarification

Comments

@pytestbot
Copy link
Contributor

Originally reported by: Travis Johnson (BitBucket: conslo, GitHub: conslo)


This statement: https://bitbucket.org/hpk42/pytest/src/d91265465608bd3777ab0c882e5d68335d7472dd/doc/en/fixture.txt?at=default#cl-100
is false, the test failure provided for the example fails on the line before the assert 0 for some unrelated reason. Personally I think just removing the assert "merlinux" in msg line and re-producing the test failure output should be good, fixing what appears to be a bug is a bit out of scope.


@pytestbot pytestbot added type: bug problem that needs to be addressed type: docs documentation improvement, missing or needing clarification labels Jun 15, 2015
@The-Compiler
Copy link
Member

It seems the docs have changed in the meantime - can you still reproduce this, @conslo?

@merwok
Copy link
Contributor

merwok commented Jul 8, 2015

The issue is still there http://pytest.org/latest/fixture.html#fixtures-as-function-arguments

>       assert "merlinux" in msg
E       TypeError: Type str doesn't support the buffer API

@nicoddemus
Copy link
Member

Thanks for the report @merwok!

It seems this issue has been fixed already in commit 43d27ec.

You can see the latest version here.

The docs page will be updated after the documentation is re-generated when a new version comes out.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug problem that needs to be addressed type: docs documentation improvement, missing or needing clarification
Projects
None yet
Development

No branches or pull requests

4 participants