Skip to content

Release 6.0.2 #7718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicoddemus opened this issue Sep 4, 2020 · 14 comments
Closed

Release 6.0.2 #7718

nicoddemus opened this issue Sep 4, 2020 · 14 comments

Comments

@nicoddemus
Copy link
Member

@pytestbot please prepare release from 6.0.x

@pytest-dev pytest-dev deleted a comment from pytestbot Sep 4, 2020
@nicoddemus
Copy link
Member Author

@pytestbot please prepare release from 6.0.x

@pytestbot
Copy link
Contributor

As requested, opened a PR for release 6.0.2: #7720.

@ssbarnea
Copy link
Member

ssbarnea commented Sep 5, 2020

Here is a good reason for not making a release https://github.com/pytest-dev/pytest/pull/7721/files -- this POC demonstrates that current code from pytest master is incompatible with pytest-cov, onve of the most popular plugins.

Apparently the plugin that is tested for compatibility is xdist and we clearly need more than this. I am not arguing that we need to perform extensive testing, but al least to confirm that simple installation of one plugin that does not render the entire ecosystem useless.

@nicoddemus
Copy link
Member Author

Here is a good reason for not making a release #7721 (files) -- this POC demonstrates that current code from pytest master is incompatible with pytest-cov, onve of the most popular plugins.

Actually 6.0.2 is not from master, but you got a point that we should at least have some basic testing in pytest itself. 👍

I will build on your PR to add a few more quick tests of various plugins.

@nicoddemus nicoddemus mentioned this issue Sep 5, 2020
@ssbarnea
Copy link
Member

ssbarnea commented Sep 5, 2020

Super! I propose to start small and grow the list of plugins slowly/carefully. A nighly job could help but only if we can send failure emails to a list that includes maintainers of both pytest and the involved plugins.

@nicoddemus
Copy link
Member Author

Super! I propose to start small and grow the list of plugins slowly/carefully. A nighly job could help but only if we can send failure emails to a list that includes maintainers of both pytest and the involved plugins.

Originally when we thought about this, we thought about running each plugin's full test suite (at least I did think that), and that of course is too expensive/flaky.

However, I think having some simple smoke tests for each plugin is easy/reasonable to do and should run quickly, so much we can integrate it with pytest's normal test environments.

@ssbarnea
Copy link
Member

ssbarnea commented Sep 5, 2020

It is key to test these in presence of other plugins, as one plugin can break an unrelated plugin. Regarding the nature of the testing, I do not have yet a solution but I will likely find one as I have few similar use-cases on other projects using pytest, where I want to include some tests with the plugins and allow their collection and execution.

Smoke testing describes quite well what we want.

@nicoddemus
Copy link
Member Author

Took the liberty of updating your PR with some smoke testing. It should not affect 6.0.2 per-se as the code which caused the regression is only on master, but we should backport the smoke testing env back into 6.0.x once it is merged on master.

@bluetech
Copy link
Member

Wanted to continue here want to clarify the releasing order (#7741) first.

@bluetech
Copy link
Member

'tis done!

github really needs a "automatically merge once CI passes" option.

Closing, please reopen if you're still having a discussion here.

@hugovk
Copy link
Member

hugovk commented Sep 12, 2020

github really needs a "automatically merge once CI passes" option.

Try https://mergify.io!

@The-Compiler
Copy link
Member

github really needs a "automatically merge once CI passes" option.

soon, hopefully: github/roadmap#107

@bluetech
Copy link
Member

@The-Compiler oh nice, they say "Q4 2020 – Oct-Dec" so hopefully soon.

@ssbarnea
Copy link
Member

No need to wait for github to implement it, there are already lots of bots that already do auto-merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants