resolve warnings

Author: tejasbadadare

lazer/contracts/sui/sources/admin.move

@@ -1,8 +1,5 @@
 module pyth_lazer::admin;
 
-use sui::tx_context::TxContext;
-use sui::object;
-
 public struct AdminCapability has key, store {
     id: UID,
 }

lazer/contracts/sui/sources/pyth_lazer.move

@@ -9,28 +9,26 @@ use pyth_lazer::state;
 use pyth_lazer::admin;
 use sui::bcs;
 use sui::ecdsa_k1::secp256k1_ecrecover;
-use sui::transfer;
-use sui::tx_context::{Self, TxContext};
-
-fun init(ctx: &mut TxContext) {
-    let s = state::new(ctx);
-    transfer::public_share_object(s);
-    let cap = admin::mint(ctx);
-    transfer::public_transfer(cap, tx_context::sender(ctx));
-}
 
 const SECP256K1_SIG_LEN: u32 = 65;
 const UPDATE_MESSAGE_MAGIC: u32 = 1296547300;
 const PAYLOAD_MAGIC: u32 = 2479346549;
 
 
 // TODO:
-// initializer
-// administration -> admin cap, upgrade cap, governance?
-// storage module -> trusted signers, update fee?, treasury?
 // error handling
 // standalone verify signature function
 
+/// Initializes the module. Called at publish time. 
+/// Creates and shares the singular State object.
+/// Creates the singular AdminCapability and transfers it to the deployer.
+fun init(ctx: &mut TxContext) {
+    let s = state::new(ctx);
+    transfer::public_share_object(s);
+    let cap = admin::mint(ctx);
+    transfer::public_transfer(cap, tx_context::sender(ctx));
+}
+
 /// Parse the Lazer update message and validate the signature.
 ///
 /// The parsing logic is based on the Lazer rust protocol definition defined here:

lazer/contracts/sui/sources/state.move

@@ -47,11 +47,11 @@ public fun get_trusted_signers(s: &State): &vector<TrustedSignerInfo> {
     &s.trusted_signers
 }
 
-/// Upsert a trusted signer's information or remove them.
+/// Upsert a trusted signer's information or remove them. Can only be called by the AdminCapability holder.
 /// - If the trusted signer pubkey already exists, the expires_at will be updated.
 ///   - If the expired_at is set to zero, the trusted signer will be removed.
 /// - If the pubkey isn't found, it is added as a new trusted signer with the given expires_at.
-public(package) fun update_trusted_signer(_admin: &AdminCapability, s: &mut State, pubkey: vector<u8>, expires_at: u64) {
+public(package) fun update_trusted_signer(_: &AdminCapability, s: &mut State, pubkey: vector<u8>, expires_at: u64) {
     assert!(vector::length(&pubkey) as u64 == ED25519_PUBKEY_LEN, EInvalidPubkeyLen);
 
     let mut maybe_idx = find_signer_index(&s.trusted_signers, &pubkey);